Various protected group changes #7146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/lypqsuxkxulr
branch
2 times, most recently
from
4ab43d6 to
355ceaa
Compare
link2xt
changed the title
The messages are end-to-end encrypted in encrypted group regardless of whether the group is protected or not.
UIs now display green checkmark in a profile if the contact is verified. Chats with key-contacts cannot become unprotected, so there is no need to check 1:1 chat.
link2xt
force-pushed
the
link2xt/lypqsuxkxulr
branch
from
2000568 to
04eda07
Compare
iequidoo
approved these changes
Sep 2, 2025
| @@ -1693,12 +1693,6 @@ async fn add_parts( | |||
| let name: &str = from.display_name.as_ref().unwrap_or(&from.addr); | |||
| for part in &mut mime_parser.parts { | |||
| part.param.set(Param::OverrideSenderDisplayname, name); | |||
There was a problem hiding this comment.
This usage of OverrideSenderDisplayname looks unnecessarily overloaded, i'd prefer we use smth else for this case. But maybe some translated string like "~non-member: NAME" would be good, at least this "~" won't cause confusion
| @@ -422,7 +422,7 @@ pub enum Config { | |||
| /// Regardless of this setting, `chat.is_protected()` returns true while the key is verified, | |||
| /// and when the key changes, an info message is posted into the chat. | |||
| /// 0=Nothing else happens when the key changes. | |||
| /// 1=After the key changed, `can_send()` returns false and `is_protection_broken()` returns true | |||
| /// 1=After the key changed, `can_send()` returns false | |||
There was a problem hiding this comment.
This actually cannot happen to key-contacts. We should remove this setting, it is only used in get_info() for logging its value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out of #7116
create_chatso can be seen as a refactoring.